feat: Add code quality findings support#4330
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gmlewis
changed the title
Andrei-hub11
force-pushed
the
feat/code-quality-findings
branch
from
1f70f5b to
2d481e2
Compare
| - name: POST /hub | ||
| documentation_url: https://docs.github.com/webhooks/about-webhooks-for-repositories#pubsubhubbub | ||
| - name: GET /organizations/{organization_id} | ||
| - name: GET /repos/{owner}/{repo}/code-quality/findings |
There was a problem hiding this comment.
This file should not be hand-edited, so you will need to revert the changes to this file.
I'm on my phone now, but tomorrow I can update this file in a separate PR which you can then pull into this PR so we can move forward with it.
There was a problem hiding this comment.
I got confused because one of the CI scripts seems to require this. Maybe I missed something.
There was a problem hiding this comment.
OK, I have now merged #4331 so you should be able to switch to the master branch, perform a git pull and then switch back to this PR's branch and git merge master and then hopefully you will be able to discard all local changes you made to this file (choose ALL the remote changes when you get a merge conflict). Please let me know if you need help. (It would actually be easier if you REVERT all the changes to this file BEFORE you git merge master into this PR.)
There was a problem hiding this comment.
I've rebased this branch on top of master. @gmlewis
Andrei-hub11
force-pushed
the
feat/code-quality-findings
branch
from
2d481e2 to
681fa0f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4330 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 193 193
Lines 19400 19440 +40
=======================================
+ Hits 18912 18952 +40
Misses 270 270
Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Andrei-hub11
force-pushed
the
feat/code-quality-findings
branch
from
681fa0f to
c87d53b
Compare
Andrei-hub11
force-pushed
the
feat/code-quality-findings
branch
from
c87d53b to
85da624
Compare
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Andrei-hub11 and @alexandear!
LGTM.
Merging.
3 participants
Adds support for the REST Code Quality findings endpoints in go-github.
This includes ListFindings and GetFinding on CodeQualityService, the finding data models, unit tests, generated accessors, a pagination iterator, and manual metadata entries in openapi_operations.yaml so the change stays aligned with the project's documentation and code generation patterns.
Closes: #4327